Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 14153004: Implement missing features to run Hello world! on simulated ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 21581)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -662,12 +662,25 @@
void FlowGraphCompiler::GenerateInlinedGetter(intptr_t offset) {
- UNIMPLEMENTED();
+ // LR: return address.
+ // SP: receiver.
+ // Sequence node has one return node, its input is load field node.
+ __ ldr(R0, Address(SP, 0 * kWordSize));
+ __ LoadFromOffset(kLoadWord, R0, R0, offset - kHeapObjectTag);
+ __ Ret();
}
void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) {
- UNIMPLEMENTED();
+ // LR: return address.
+ // SP+1: receiver.
+ // SP+0: value.
+ // Sequence node has one store node and one return NULL node.
+ __ ldr(R0, Address(SP, 1 * kWordSize)); // Receiver.
+ __ ldr(R1, Address(SP, 0 * kWordSize)); // Value.
+ __ StoreIntoObject(R0, FieldAddress(R0, offset), R1);
+ __ LoadImmediate(R0, reinterpret_cast<intptr_t>(Object::null()));
+ __ Ret();
}
@@ -1101,7 +1114,7 @@
intptr_t index_scale,
Register array,
Register index) {
- UNIMPLEMENTED();
+ UNREACHABLE(); // No register indexed with offset addressing mode on ARM.
return FieldAddress(array, index);
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698