Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 14153004: Implement missing features to run Hello world! on simulated ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 21565)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -1988,8 +1988,9 @@
// Check if the instantiator type argument vector is a TypeArguments of a
// matching length and, if so, use it as the instantiated type_arguments.
- // No need to check the instantiator (RAX) for null here, because a null
- // instantiator will have the wrong class (Null instead of TypeArguments).
+ // No need to check the instantiator ('instantiator_reg') for null here,
+ // because a null instantiator will have the wrong class (Null instead of
+ // TypeArguments).
__ CompareClassId(instantiator_reg, kTypeArgumentsCid);
__ j(NOT_EQUAL, &done, Assembler::kNearJump);
const Immediate& arguments_length =

Powered by Google App Engine
This is Rietveld 408576698