runtime/bin/gen_snapshot.cc - Issue 14153004: Implement missing features to run Hello world! on simulated ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 14153004: Implement missing features to run Hello world! on simulated ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/gen_snapshot.cc

===================================================================

--- runtime/bin/gen_snapshot.cc (revision 21565)

+++ runtime/bin/gen_snapshot.cc (working copy)

@@ -428,8 +428,10 @@

static void SetupForGenericSnapshotCreation() {

SetupForUriResolution();

- // TODO(regis): Reenable this code for arm and mips when possible.

-#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)

+ // TODO(regis): Reenable this code for mips when possible.

+#if defined(TARGET_ARCH_IA32) || \

+ defined(TARGET_ARCH_X64) || \

+ defined(TARGET_ARCH_ARM)

Dart_Handle library = LoadGenericSnapshotCreationScript(Builtin::kIOLibrary);

VerifyLoaded(library);

#endif

« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | runtime/vm/intermediate_language_arm.cc » ('J')