Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1415283003: Adapt tests in preparation of shipping --harmony-completion. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adapt tests in preparation of shipping --harmony-completion. R=rossberg BUG= Committed: https://crrev.com/8e89e8203b3c4431155f82c5fdb3e7f2c914acee Cr-Commit-Position: refs/heads/master@{#31507}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M test/mjsunit/es6/block-for.js View 1 2 chunks +15 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 2 chunks +5 lines, -1 line 0 comments Download
M test/webkit/eval-throw-return.js View 2 chunks +0 lines, -5 lines 0 comments Download
M test/webkit/eval-throw-return-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M test/webkit/fast/js/basic-strict-mode.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/webkit/fast/js/basic-strict-mode-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M test/webkit/fast/js/kde/completion.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/fast/js/kde/completion-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
5 years, 2 months ago (2015-10-22 13:00:24 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1415283003/diff/1/test/mjsunit/es6/block-for.js File test/mjsunit/es6/block-for.js (right): https://codereview.chromium.org/1415283003/diff/1/test/mjsunit/es6/block-for.js#newcode200 test/mjsunit/es6/block-for.js:200: eval("for (let i = 0; i < 10; ...
5 years, 2 months ago (2015-10-22 16:07:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415283003/20001
5 years, 2 months ago (2015-10-23 09:15:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-23 10:25:55 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 10:26:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e89e8203b3c4431155f82c5fdb3e7f2c914acee
Cr-Commit-Position: refs/heads/master@{#31507}

Powered by Google App Engine
This is Rietveld 408576698