Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1415243002: Add a recipe for fetching pdfium. (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, agable, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Add a recipe for fetching pdfium. With this, `fetch pdfium` is all that's needed to get a pdfium checkout. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A recipes/pdfium.py View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nico
thestig to decide if this is useful, iannucci to review if it is
5 years, 2 months ago (2015-10-21 20:13:40 UTC) #2
Lei Zhang
FYI, we had a fetch pdfium recipe before, but it was deleted because it didn't ...
5 years, 2 months ago (2015-10-21 20:20:40 UTC) #3
Nico
But now pdfium is no longer doing the weird thing, right? On Wed, Oct 21, ...
5 years, 2 months ago (2015-10-21 20:26:14 UTC) #4
Lei Zhang
Sure, go for it. Previous CL: https://codereview.chromium.org/1382543002
5 years, 2 months ago (2015-10-21 20:30:54 UTC) #5
Nico
iannucci: ping
5 years, 1 month ago (2015-10-27 16:37:46 UTC) #6
Nico
hm, looks like iannucci is away. agable, can you owners-approve this?
5 years, 1 month ago (2015-10-27 18:37:03 UTC) #8
agable
Totally works. lgtm!
5 years, 1 month ago (2015-10-27 20:26:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415243002/1
5 years, 1 month ago (2015-10-27 20:30:43 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 20:32:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297340

Powered by Google App Engine
This is Rietveld 408576698