Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 141523011: Only include chromevox_test_data in isolated swarming tests for chromeos builds. (Closed)

Created:
6 years, 10 months ago by Peter Lundblad
Modified:
6 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Only include chromevox_test_data in isolated swarming tests for chromeos builds. BUG=338749 R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248069

Patch Set 1 #

Patch Set 2 : Add support for chromeos==1. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/android/pylib/gtest/setup.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/isolate.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser_tests.isolate View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Lundblad
6 years, 10 months ago (2014-01-30 20:15:00 UTC) #1
M-A Ruel
lgtm, thanks!
6 years, 10 months ago (2014-01-30 20:49:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/141523011/40001
6 years, 10 months ago (2014-01-30 20:50:04 UTC) #3
commit-bot: I haz the power
Change committed as 248069
6 years, 10 months ago (2014-01-30 23:20:27 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 23:20:29 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698