chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sky's review Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index a78f46eb371ae87b07efc5425d7066c469e1cd53..dc70a594814bfd32bc30eeb97435d3748c0534fe 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -475,7 +475,7 @@ views::View* TranslateBubbleView::CreateViewBeforeTranslate() {

new TranslateDenialComboboxModel(original_language_name));

denial_combobox_->set_id(COMBOBOX_ID_DENIAL);

denial_combobox_->set_listener(this);

- denial_combobox_->SetStyle(views::Combobox::STYLE_NOTIFY_ON_CLICK);

+ denial_combobox_->SetStyle(views::Combobox::STYLE_ACTION);

views::View* view = new views::View();

views::GridLayout* layout = new views::GridLayout(view);

« no previous file with comments | « no previous file | ui/views/controls/combobox/combobox.h » ('j') | ui/views/controls/combobox/combobox.cc » ('J')