chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc - Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug fix for Windows Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

index 4802d27f9ccbbe3febb253e6bcff778576f40c4c..271563388e3b4b0a380126b102a8a5f0cdb7577e 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

@@ -258,10 +258,10 @@ TEST_F(TranslateBubbleViewTest, DoneButton) {

// are applied.

EXPECT_FALSE(mock_model_->translate_called_);

bubble_->source_language_combobox_->SetSelectedIndex(10);

- bubble_->HandleComboboxSelectedIndexChanged(

+ bubble_->HandleComboboxPerformAction(

TranslateBubbleView::COMBOBOX_ID_SOURCE_LANGUAGE);

bubble_->target_language_combobox_->SetSelectedIndex(20);

- bubble_->HandleComboboxSelectedIndexChanged(

+ bubble_->HandleComboboxPerformAction(

TranslateBubbleView::COMBOBOX_ID_TARGET_LANGUAGE);

bubble_->HandleButtonPressed(TranslateBubbleView::BUTTON_ID_DONE);

EXPECT_TRUE(mock_model_->translate_called_);

« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view.cc ('k') | ui/views/controls/combobox/combobox.h » ('j') | no next file with comments »