chrome/browser/ui/views/translate/translate_bubble_view.h - Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug fix for Windows Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.h

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h

index 72379ef36f0649a1260772f1943bc335a0aef60b..9a97f744baa10dc651ea293a7e8c5de8b9bbfa56 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.h

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h

@@ -64,8 +64,7 @@ class TranslateBubbleView : public views::BubbleDelegateView,

virtual gfx::Size GetPreferredSize() OVERRIDE;

// views::CombboxListener methods.

- virtual void OnSelectedIndexChanged(views::Combobox* combobox) OVERRIDE;

- virtual void OnComboboxTextButtonClicked(views::Combobox* combobox) OVERRIDE;

+ virtual void OnPerformAction(views::Combobox* combobox) OVERRIDE;

// views::LinkListener method.

virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;

@@ -131,7 +130,7 @@ class TranslateBubbleView : public views::BubbleDelegateView,

void HandleLinkClicked(LinkID sender_id);

// Handles the event when the user changes an index of a combobox.

- void HandleComboboxSelectedIndexChanged(ComboboxID sender_id);

+ void HandleComboboxPerformAction(ComboboxID sender_id);

// Updates the visibilities of child views according to the current view type.

void UpdateChildVisibilities();