Source/bindings/tests/results/V8TestSVG.cpp - Issue 141523002: Add null-correctness checking to [StrictTypeChecking] methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSVG.cpp

Issue 141523002: Add null-correctness checking to [StrictTypeChecking] methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Last test Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestSVG.cpp

diff --git a/Source/bindings/tests/results/V8TestSVG.cpp b/Source/bindings/tests/results/V8TestSVG.cpp

index d086c8c4cb1c4b5a5842d7f659059162c53d8784..4675f696d89a867f757f9b79dc72be0dba8d0df3 100644

--- a/Source/bindings/tests/results/V8TestSVG.cpp

+++ b/Source/bindings/tests/results/V8TestSVG.cpp

@@ -270,7 +270,7 @@ static void strictSVGPointMethodMethod(const v8::FunctionCallbackInfo<v8::Value>

return;

}

TestSVG* imp = V8TestSVG::toNative(info.Holder());

- if (info.Length() > 0 && !isUndefinedOrNull(info[0]) && !V8SVGPoint::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate()))) {

+ if (info.Length() > 0 && !info[0]->IsUndefined() && !V8SVGPoint::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate()))) {

exceptionState.throwTypeError("parameter 1 is not of type 'SVGPoint'.");

exceptionState.throwIfNeeded();

return;