Source/core/svg/SVGNumberList.idl - Issue 141523002: Add null-correctness checking to [StrictTypeChecking] methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGNumberList.idl

Issue 141523002: Add null-correctness checking to [StrictTypeChecking] methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGNumberList.idl

diff --git a/Source/core/svg/SVGNumberList.idl b/Source/core/svg/SVGNumberList.idl

index 4711cc66379a1f67163f0cb1b373e5398807ee52..254e5a9d820ec515b172ecaeb836104220cd1334 100644

--- a/Source/core/svg/SVGNumberList.idl

+++ b/Source/core/svg/SVGNumberList.idl

@@ -28,11 +28,11 @@ interface SVGNumberList {

readonly attribute unsigned long numberOfItems;

[RaisesException] void clear();

- [StrictTypeChecking, RaisesException] SVGNumber initialize(SVGNumber item);

+ [StrictTypeChecking, RaisesException] SVGNumber initialize(SVGNumber? item);

kouhei (in TOK) 2014/01/17 04:28:45 No ? here.

[StrictTypeChecking, RaisesException] SVGNumber getItem(unsigned long index);

- [StrictTypeChecking, RaisesException] SVGNumber insertItemBefore(SVGNumber item, unsigned long index);

- [StrictTypeChecking, RaisesException] SVGNumber replaceItem(SVGNumber item, unsigned long index);

+ [StrictTypeChecking, RaisesException] SVGNumber insertItemBefore(SVGNumber? item, unsigned long index);

kouhei (in TOK) 2014/01/17 04:28:45 No ? here.

+ [StrictTypeChecking, RaisesException] SVGNumber replaceItem(SVGNumber? item, unsigned long index);

kouhei (in TOK) 2014/01/17 04:28:45 No ? here.

[StrictTypeChecking, RaisesException] SVGNumber removeItem(unsigned long index);

- [StrictTypeChecking, RaisesException] SVGNumber appendItem(SVGNumber item);

+ [StrictTypeChecking, RaisesException] SVGNumber appendItem(SVGNumber? item);

};

kouhei (in TOK) 2014/01/17 04:28:45 No ? here.