Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: Source/core/svg/SVGLengthList.idl

Issue 141523002: Add null-correctness checking to [StrictTypeChecking] methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGLengthList.idl
diff --git a/Source/core/svg/SVGLengthList.idl b/Source/core/svg/SVGLengthList.idl
index 2e66d4384c3f994888174ddc3c969390a36728d0..bc324889a01e1e967a8dea8f233e71c565e58c37 100644
--- a/Source/core/svg/SVGLengthList.idl
+++ b/Source/core/svg/SVGLengthList.idl
@@ -26,16 +26,16 @@
[
ImplementedAs=SVGLengthListTearOff,
- SetReference(SVGElement contextElement)
+ SetReference(SVGElement contextElement),
kouhei (in TOK) 2014/01/17 04:28:45 Is this intentional?
] interface SVGLengthList {
readonly attribute unsigned long numberOfItems;
[RaisesException] void clear();
- [StrictTypeChecking, RaisesException] SVGLength initialize(SVGLength item);
+ [StrictTypeChecking, RaisesException] SVGLength initialize(SVGLength? item);
kouhei (in TOK) 2014/01/17 04:28:45 No ? here.
[StrictTypeChecking, RaisesException] SVGLength getItem(unsigned long index);
- [StrictTypeChecking, RaisesException] SVGLength insertItemBefore(SVGLength item, unsigned long index);
- [StrictTypeChecking, RaisesException] SVGLength replaceItem(SVGLength item, unsigned long index);
+ [StrictTypeChecking, RaisesException] SVGLength insertItemBefore(SVGLength? item, unsigned long index);
kouhei (in TOK) 2014/01/17 04:28:45 no ? here.
+ [StrictTypeChecking, RaisesException] SVGLength replaceItem(SVGLength? item, unsigned long index);
kouhei (in TOK) 2014/01/17 04:28:45 Ditto
[StrictTypeChecking, RaisesException] SVGLength removeItem(unsigned long index);
- [StrictTypeChecking, RaisesException] SVGLength appendItem(SVGLength item);
+ [StrictTypeChecking, RaisesException] SVGLength appendItem(SVGLength? item);
kouhei (in TOK) 2014/01/17 04:28:45 Ditto
};

Powered by Google App Engine
This is Rietveld 408576698