Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415223005: Reorder chrome/test/BUILD.gn to match order in chrome_tests_unit.gypi (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder chrome/test/BUILD.gn to match order in chrome_tests_unit.gypi BUG=510485 Committed: https://crrev.com/fe1b9618b8953f062d28e860853197d91bba8003 Cr-Commit-Position: refs/heads/master@{#357006}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -66 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 chunks +25 lines, -25 lines 0 comments Download
M chrome/test/BUILD.gn View 1 6 chunks +42 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Scott, can you please take a look?
5 years, 1 month ago (2015-10-29 19:31:21 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-10-29 23:02:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415223005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415223005/20001
5 years, 1 month ago (2015-10-29 23:39:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 01:05:00 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:06:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe1b9618b8953f062d28e860853197d91bba8003
Cr-Commit-Position: refs/heads/master@{#357006}

Powered by Google App Engine
This is Rietveld 408576698