Add counts of User data to ProfileInfoCache

chrome/browser/profiles/profile_attributes_entry.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_attributes_entry.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 
 ProfileAttributesEntry::ProfileAttributesEntry()
     : profile_info_cache_(nullptr),
       profile_path_(base::FilePath()) {}
@@ skipping 112 matching lines @@
 
 bool ProfileAttributesEntry::IsAuthError() const {
   return profile_info_cache_->ProfileIsAuthErrorAtIndex(profile_index());
 }
 
 size_t ProfileAttributesEntry::GetAvatarIconIndex() const {
   return profile_info_cache_->GetAvatarIconIndexOfProfileAtIndex(
       profile_index());
 }
 
+bool ProfileAttributesEntry::GetStatistic(const std::string& category,

[anthonyvd, 2015/10/23 15:53:14]

I think this (and the ProfileInfoCache implementation) can just return the value
directly and return 0 for items we don't have data for. After all, the count of
an item we don't know about is still 0 and someone *really* interested in the
counts that have associated data can use GetAllStatistics().

If you go down that road, please add a test around getting a count that's not in
the PIC yet.

[lwchkg, 2015/10/24 02:02:32]

I see. It's okay here because everything else in this file returns a default
value in similar cases.
It's already there. The keys "One", "Two" and "Three" are tested every time we
add an value to the cache. The same keys are also tested before the first value
is added to the cache.

+                                          int* out_value) const {
+  return profile_info_cache_->GetStatisticOfProfileAtIndex(
+      profile_index(), category, out_value);
+}
+
+std::map<std::string, int> ProfileAttributesEntry::GetAllStatistics() const {
+  return profile_info_cache_->GetAllStatisticsOfProfileAtIndex(profile_index());
+}
+
+scoped_ptr<base::DictionaryValue>
+    ProfileAttributesEntry::GetAllStatisticsAsDictionaryValue() const {
+  return profile_info_cache_->GetAllStatisticsOfProfileAtIndexAsDictionaryValue(
+      profile_index()).Pass();
+}
+
 void ProfileAttributesEntry::SetName(const base::string16& name) {
   profile_info_cache_->SetNameOfProfileAtIndex(profile_index(), name);
 }
 
 void ProfileAttributesEntry::SetShortcutName(const base::string16& name) {
   profile_info_cache_->SetShortcutNameOfProfileAtIndex(profile_index(), name);
 }
 
 void ProfileAttributesEntry::SetIsOmitted(bool is_omitted) {
   profile_info_cache_->SetIsOmittedProfileAtIndex(profile_index(), is_omitted);
@@ skipping 56 matching lines @@
 
 void ProfileAttributesEntry::SetIsAuthError(bool value) {
   profile_info_cache_->SetProfileIsAuthErrorAtIndex(profile_index(), value);
 }
 
 void ProfileAttributesEntry::SetAvatarIconIndex(size_t icon_index) {
   profile_info_cache_->SetAvatarIconOfProfileAtIndex(
       profile_index(), icon_index);
 }
 
+void ProfileAttributesEntry::SetStatistic(const std::string& category,
+                                          int value) {
+  profile_info_cache_->SetStatisticOfProfileAtIndex(
+      profile_index(), category, value);
+}
+
 void ProfileAttributesEntry::SetAuthInfo(
     const std::string& gaia_id, const base::string16& user_name) {
   profile_info_cache_->SetAuthInfoOfProfileAtIndex(
       profile_index(), gaia_id, user_name);
 }
 
 size_t ProfileAttributesEntry::profile_index() const {
   size_t index = profile_info_cache_->GetIndexOfProfileWithPath(profile_path_);
   DCHECK(index < profile_info_cache_->GetNumberOfProfiles());
   return index;
 }