Add counts of User data to ProfileInfoCache

chrome/browser/profiles/profile_attributes_storage_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/supervised_user/supervised_user_constants.h"
 #include "chrome/test/base/testing_browser_process.h"
@@ skipping 16 matching lines @@
     TEST_ACCESSORS(entry_type, entry, member, \
         base::ASCIIToUTF16("first_" #member "_value"), \
         base::ASCIIToUTF16("second_" #member "_value"));
 
 #define TEST_STRING_ACCESSORS(entry_type, entry, member) \
     TEST_ACCESSORS(entry_type, entry, member, \
         std::string("first_" #member "_value"), \
         std::string("second_" #member "_value"));
 
 #define TEST_BOOL_ACCESSORS(entry_type, entry, member) \
-TestAccessors(&entry, \
-              &entry_type::member, \
-              &entry_type::Set ## member, \
-              false, \
-              true);
+    TestAccessors(&entry, \
+                  &entry_type::member, \
+                  &entry_type::Set ## member, \
+                  false, \
+                  true);
+
+#define TEST_STAT_ACCESSORS(entry_type, entry, member) \
+    TestStatAccessors(&entry, \
+                      &entry_type::Has ## member, \
+                      &entry_type::Get ## member, \
+                      &entry_type::Set ## member, \
+                      10, \
+                      20);
 
 template<typename TValue, typename TGetter, typename TSetter>
 void TestAccessors(ProfileAttributesEntry** entry,
     TGetter getter_func,
     TSetter setter_func,
     TValue first_value,
     TValue second_value) {
   (*entry->*setter_func)(first_value);
   EXPECT_EQ(first_value, (*entry->*getter_func)());
   (*entry->*setter_func)(second_value);
   EXPECT_EQ(second_value, (*entry->*getter_func)());
 }
+
+template<typename TValue, typename TExist, typename TGetter, typename TSetter>
+void TestStatAccessors(ProfileAttributesEntry** entry,
+    TExist exist_func,
+    TGetter getter_func,
+    TSetter setter_func,
+    TValue first_value,
+    TValue second_value) {
+  EXPECT_FALSE((*entry->*exist_func)());
+  (*entry->*setter_func)(first_value);
+  EXPECT_TRUE((*entry->*exist_func)());
+  EXPECT_EQ(first_value, (*entry->*getter_func)());
+  (*entry->*setter_func)(second_value);
+  EXPECT_TRUE((*entry->*exist_func)());
+  EXPECT_EQ(second_value, (*entry->*getter_func)());
+}
 }  // namespace
 
 class ProfileAttributesStorageTest : public testing::Test {
  public:
   ProfileAttributesStorageTest()
       : testing_profile_manager_(TestingBrowserProcess::GetGlobal()) {}
   ~ProfileAttributesStorageTest() override {}
 
  protected:
   void SetUp() override {
@@ skipping 11 matching lines @@
   ProfileAttributesStorage* storage() {
     return profile_info_cache();
   }
 
   ProfileInfoCache* profile_info_cache() {
     return testing_profile_manager_.profile_info_cache();
   }
 
   void AddTestingProfile() {
     unsigned long number_of_profiles =
         static_cast<unsigned long>(storage()->GetNumberOfProfiles());

[lwchkg, 2015/11/15 19:40:06]

Should this be simply "size_t" without casting? If yes I'll change it in this
CL.

[Mike Lerman, 2015/11/17 16:29:51]

Yes, just use size_t where that's the defined type.

[lwchkg, 2015/11/18 17:34:53]

Done.

 
     storage()->AddProfile(
         GetProfilePath(
             base::StringPrintf("testing_profile_path%lu", number_of_profiles)),
         base::ASCIIToUTF16(
             base::StringPrintf("testing_profile_name%lu", number_of_profiles)),
         std::string(
             base::StringPrintf("testing_profile_gaia%lu", number_of_profiles)),
         base::ASCIIToUTF16(
             base::StringPrintf("testing_profile_user%lu", number_of_profiles)),
@@ skipping 80 matching lines @@
       GetProfilePath("testing_profile_path0"), &entry));
   EXPECT_EQ(base::ASCIIToUTF16("testing_profile_name0"), entry->GetName());
 
   storage()->RemoveProfile(GetProfilePath("testing_profile_path0"));
   ASSERT_FALSE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path0"), &entry));
   EXPECT_EQ(4U, storage()->GetNumberOfProfiles());
 
   std::vector<ProfileAttributesEntry*> entries =
       storage()->GetAllProfilesAttributes();
-  for (auto& entry: entries) {
+  for (auto& entry : entries) {
     EXPECT_NE(GetProfilePath("testing_profile_path0"), entry->GetPath());
   }
 }
 
 TEST_F(ProfileAttributesStorageTest, InitialValues) {
   AddTestingProfile();
 
   ProfileAttributesEntry* entry;
   ASSERT_TRUE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path0"), &entry));
@@ skipping 23 matching lines @@
   TEST_STRING16_ACCESSORS(ProfileAttributesEntry, entry, GAIAName);
   TEST_STRING16_ACCESSORS(ProfileAttributesEntry, entry, GAIAGivenName);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsUsingGAIAPicture);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsOmitted);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsSigninRequired);
   TEST_STRING_ACCESSORS(ProfileAttributesEntry, entry, SupervisedUserId);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsEphemeral);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsUsingDefaultName);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsUsingDefaultAvatar);
   TEST_BOOL_ACCESSORS(ProfileAttributesEntry, entry, IsAuthError);
+
+  TEST_STAT_ACCESSORS(ProfileAttributesEntry, entry, StatsBrowsingHistory);
+  TEST_STAT_ACCESSORS(ProfileAttributesEntry, entry, StatsBookmarks);
+  TEST_STAT_ACCESSORS(ProfileAttributesEntry, entry, StatsPasswords);
+  TEST_STAT_ACCESSORS(ProfileAttributesEntry, entry, StatsSettings);
 }
 
 TEST_F(ProfileAttributesStorageTest, AuthInfo) {
   AddTestingProfile();
 
   ProfileAttributesEntry* entry;
   ASSERT_TRUE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path0"), &entry));
 
   entry->SetAuthInfo("", base::string16());
@@ skipping 63 matching lines @@
 
   ProfileAttributesEntry* first_entry;
   ASSERT_TRUE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path0"), &first_entry));
 
   ProfileAttributesEntry* second_entry;
   ASSERT_TRUE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path1"), &second_entry));
 
   EXPECT_EQ(
-      base::ASCIIToUTF16("testing_profile_name0"),first_entry->GetName());
+      base::ASCIIToUTF16("testing_profile_name0"), first_entry->GetName());
 
   storage()->RemoveProfile(GetProfilePath("testing_profile_path1"));
   ASSERT_FALSE(storage()->GetProfileAttributesWithPath(
       GetProfilePath("testing_profile_path1"), &second_entry));
 
   EXPECT_EQ(GetProfilePath("testing_profile_path0"), first_entry->GetPath());
   EXPECT_EQ(
       base::ASCIIToUTF16("testing_profile_name0"), first_entry->GetName());
 
   // Deleting through the ProfileInfoCache should be reflected in the
@@ skipping 23 matching lines @@
   // should be reflected by the ProfileAttributesStorage.
   size_t index = profile_info_cache()->GetIndexOfProfileWithPath(
       GetProfilePath("testing_profile_path0"));
   EXPECT_EQ(base::ASCIIToUTF16("NewName"),
       profile_info_cache()->GetNameOfProfileAtIndex(index));
 
   profile_info_cache()->SetNameOfProfileAtIndex(
       index, base::ASCIIToUTF16("OtherNewName"));
   EXPECT_EQ(base::ASCIIToUTF16("OtherNewName"), first_entry->GetName());
 }