Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415213003: VideoPlayer: Show fullscreen-exit button when the player window is fullscreened. (Closed)

Created:
5 years, 2 months ago by fukino
Modified:
5 years, 2 months ago
Reviewers:
yawano
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: Show fullscreen-exit button when the player window is fullscreened. BUG=488229 TEST=manually Committed: https://crrev.com/e45bf7dd7f3216b34186ccf940d2fe3f56a5f5a9 Cr-Commit-Position: refs/heads/master@{#355516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M ui/file_manager/video_player/css/media_controls.css View 1 chunk +6 lines, -0 lines 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_fullscreen_exit.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_fullscreen_exit.png View Binary file 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 2 months ago (2015-10-22 07:31:58 UTC) #2
yawano
lgtm. Thank you!
5 years, 2 months ago (2015-10-22 08:17:47 UTC) #3
fukino
On 2015/10/22 08:17:47, yawano wrote: > lgtm. Thank you! Thank you!
5 years, 2 months ago (2015-10-22 08:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415213003/1
5 years, 2 months ago (2015-10-22 08:24:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 08:53:25 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 08:54:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e45bf7dd7f3216b34186ccf940d2fe3f56a5f5a9
Cr-Commit-Position: refs/heads/master@{#355516}

Powered by Google App Engine
This is Rietveld 408576698