Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1415193006: bin/deps-and-gyp: deal with corner cases cleanly (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

bin/deps-and-gyp: deal with corner cases cleanly TBR=mtklein@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/4a40a46c654f292b9407fe42012831855411f75e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M bin/deps-and-gyp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hal.canary
5 years, 1 month ago (2015-11-03 19:17:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415193006/1
5 years, 1 month ago (2015-11-03 19:17:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4a40a46c654f292b9407fe42012831855411f75e
5 years, 1 month ago (2015-11-03 19:18:13 UTC) #5
mtklein
5 years, 1 month ago (2015-11-03 19:20:55 UTC) #6
Message was sent while issue was closed.
On 2015/11/03 at 19:18:13, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4a40a46c654f292b9407fe42012831855411f75e

~/skia (master) $ git cl patch 1415193006
Committed patch locally.
~/skia (master) $ time sh bin/deps-and-gyp
        0.45 real         0.61 user         0.53 sys
~/skia (master) $ time sh bin/deps-and-gyp
        0.36 real         0.36 user         0.40 sys
~/skia (master) $ time sh bin/deps-and-gyp
        0.35 real         0.37 user         0.40 sys

lgtm

Powered by Google App Engine
This is Rietveld 408576698