Issue 1415173003: Replace flags in summary IDL with enums and booleans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415173003: Replace flags in summary IDL with enums and booleans. (Closed)

Created:
5 years, 2 months ago by Paul Berry

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Replace flags in summary IDL with enums and booleans. We can let code generation compress these enums and booleans into a flag integer if necessary to save space. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7995c8ef1e8b3f9a5b18b42f553b77ab64ae7f6d

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -63 lines)			Patch
	M	pkg/analyzer/tool/summary/idl.dart	View		12 chunks	+166 lines, -63 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1415173003/diff/1/pkg/analyzer/tool/summary/idl.dart File pkg/analyzer/tool/summary/idl.dart (right): https://codereview.chromium.org/1415173003/diff/1/pkg/analyzer/tool/summary/idl.dart#newcode691 pkg/analyzer/tool/summary/idl.dart:691: bool isFactory; I think this should be "isConst".

5 years, 2 months ago (2015-10-21 20:21:08 UTC) #3

Paul Berry

5 years, 2 months ago (2015-10-21 20:50:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7995c8ef1e8b3f9a5b18b42f553b77ab64ae7f6d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages