Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415163008: fix an embedder test in XFA branch (Closed)

Created:
5 years, 1 month ago by Wei Li
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

fix an embedder test in XFA branch. The merge https://codereview.chromium.org/1411403012/ broken build since there are one more embedder test in XFA branch. Fix this test in this CL. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3d632f023a2e1c4a29512fca3dfe723f4f474c59

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M xfa/src/fxfa/src/parser/xfa_parser_imp_embeddertest.cpp View 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Wei Li
PTAL, thanks
5 years, 1 month ago (2015-11-09 20:36:57 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1415163008/diff/1/xfa/src/fxfa/src/parser/xfa_parser_imp_embeddertest.cpp File xfa/src/fxfa/src/parser/xfa_parser_imp_embeddertest.cpp (right): https://codereview.chromium.org/1415163008/diff/1/xfa/src/fxfa/src/parser/xfa_parser_imp_embeddertest.cpp#newcode5 xfa/src/fxfa/src/parser/xfa_parser_imp_embeddertest.cpp:5: #include "testing/embedder_test.h" I can't remember if I fixed ...
5 years, 1 month ago (2015-11-09 20:38:02 UTC) #3
Wei Li
5 years, 1 month ago (2015-11-09 20:41:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3d632f023a2e1c4a29512fca3dfe723f4f474c59 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698