build: Allow glib to be disabled for non-ozone builds of chromium when using GN.

build: Allow glib to be disabled for non-ozone builds of chromium when using GN.

gyp allows glib to be disabled using -Duse_glib=0. This allows glib
to also be disabled when using GN.

BUG=
TEST=gn args out/Default; use_glib = false; Build and run.

Committed: https://crrev.com/c7fa280a146882d692656ba42f2e99d1fea9f92c
Cr-Commit-Position: refs/heads/master@{#358188}

[reveman, 2015-11-05 16:36:52]

reveman@chromium.org changed reviewers:
+ dpranke@chromium.org

[reveman, 2015-11-05 16:37:02]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 16:38:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415153007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415153007/1

[commit-bot: I haz the power, 2015-11-05 17:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 17:17:18]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-11-05 22:19:21]

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni#newcode47
build/config/ui.gni:47: use_glib = is_linux && !use_ozone
This change probably doesn't do what you expect it to do.

See crbug.com/542846.

Depending on what you want to have happen, you might need to do:

declare_args() {
  use_glib = ''
}

if (use_glib == '') {
  use_glib = is-linux && !use_ozne
}

In order for it to be set correctly if one sets use_ozone explicitly in args.gn.

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni#newcode63
build/config/ui.gni:63: if (is_linux && !use_ozone) {
I'm not sure I understand this change. Are you saying
that whether we should use cairo and pango only depends
on ozone, and not glib?

[reveman, 2015-11-05 23:15:07]

ptal

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni#newcode47
build/config/ui.gni:47: use_glib = is_linux && !use_ozone
On 2015/11/05 at 22:19:21, Dirk Pranke wrote:
> This change probably doesn't do what you expect it to do.
> 
> See crbug.com/542846.
> 
> Depending on what you want to have happen, you might need to do:
> 
> declare_args() {
>   use_glib = ''
> }
> 
> if (use_glib == '') {
>   use_glib = is-linux && !use_ozne
> }
> 
> In order for it to be set correctly if one sets use_ozone explicitly in
args.gn.

ah, got it.

https://codereview.chromium.org/1415153007/diff/1/build/config/ui.gni#newcode63
build/config/ui.gni:63: if (is_linux && !use_ozone) {
On 2015/11/05 at 22:19:21, Dirk Pranke wrote:
> I'm not sure I understand this change. Are you saying
> that whether we should use cairo and pango only depends
> on ozone, and not glib?

Yes, use_glib should not affect this. A non-ozone build will always need
cairo/pango right now afaict.

[Dirk Pranke, 2015-11-05 23:22:42]

ok, lgtm.

[reveman, 2015-11-05 23:26:53]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2015-11-05 23:28:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415153007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415153007/20001

[commit-bot: I haz the power, 2015-11-06 00:08:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-06 00:09:31]

Patchset 2 (id:??) landed as
https://crrev.com/c7fa280a146882d692656ba42f2e99d1fea9f92c
Cr-Commit-Position: refs/heads/master@{#358188}