Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: pkg/analyzer/test/source/analysis_options_provider_test.dart

Issue 1415153004: Improved YAML doc exception handling. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/source/analysis_options_provider.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/source/analysis_options_provider_test.dart
diff --git a/pkg/analyzer/test/source/analysis_options_provider_test.dart b/pkg/analyzer/test/source/analysis_options_provider_test.dart
index 4cf41fde091c4d6d1646fb14af1d38fca94ff23e..5d743e4238bea57c3e5c671cdee3a7dbf32f3429 100644
--- a/pkg/analyzer/test/source/analysis_options_provider_test.dart
+++ b/pkg/analyzer/test/source/analysis_options_provider_test.dart
@@ -75,12 +75,31 @@ main() {
expect(exceptionCaught, isTrue);
});
});
+ group('AnalysisOptionsProvider', () {
+ test('test_bad_yaml', () {
+ var src = '''
+ analyzer:
+ exclude:
+ - test/data/*
+ error:
+ invalid_assignment: ignore
+ unused_local_variable: # <=== bang
+linter:
+ rules:
+ - camel_case_types
+''';
+
+ var optionsProvider = new AnalysisOptionsProvider();
+ expect(() => optionsProvider.getOptionsFromString(src),
+ throwsA(new isInstanceOf<OptionsFormatException>()));
+ });
+ });
}
MemoryResourceProvider resourceProvider;
-buildResourceProvider({bool emptyAnalysisOptions : false,
- bool badAnalysisOptions : false}) {
+buildResourceProvider(
+ {bool emptyAnalysisOptions: false, bool badAnalysisOptions: false}) {
resourceProvider = new MemoryResourceProvider();
resourceProvider.newFolder('/empty');
resourceProvider.newFolder('/tmp');
@@ -90,8 +109,8 @@ buildResourceProvider({bool emptyAnalysisOptions : false,
resourceProvider.newFile('/.analysis_options', r'''#empty''');
} else {
resourceProvider.newFile(
- '/.analysis_options',
- r'''
+ '/.analysis_options',
+ r'''
analyzer:
ignore:
- ignoreme.dart
« no previous file with comments | « pkg/analyzer/lib/source/analysis_options_provider.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698