Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1415153004: Improved YAML doc exception handling. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-10-28 17:44:45 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-10-28 17:48:20 UTC) #3
pquitslund
5 years, 1 month ago (2015-10-28 18:24:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffeacec73df5cd46300672324ff9a68b7451c158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698