Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

Issue 1415143005: Preparation for enabling slimming paint synchronized painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments for the loop finding real root GraphicsLayer Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
index 9f41d0fff9cd510326c12f283e12c9af643043cd..17438038ce9e232fe92b2eb84e05def94defdb5d 100644
--- a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
+++ b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
@@ -18,7 +18,6 @@
namespace blink {
using LayoutObjectDrawingRecorderTest = PaintControllerPaintTest;
-using LayoutObjectDrawingRecorderTestForSlimmingPaintV2 = PaintControllerPaintTestForSlimmingPaintV2;
namespace {
@@ -41,10 +40,9 @@ void drawRect(GraphicsContext& context, LayoutView& layoutView, PaintPhase phase
TEST_F(LayoutObjectDrawingRecorderTest, Nothing)
{
+ rootPaintController().invalidateAll();
GraphicsContext context(rootPaintController());
LayoutRect bound = layoutView().viewRect();
- EXPECT_EQ((size_t)0, rootPaintController().displayItemList().size());
-
drawNothing(context, layoutView(), PaintPhaseForeground, bound);
rootPaintController().commitNewDisplayItems();
EXPECT_DISPLAY_LIST(rootPaintController().displayItemList(), 1,
@@ -54,6 +52,7 @@ TEST_F(LayoutObjectDrawingRecorderTest, Nothing)
TEST_F(LayoutObjectDrawingRecorderTest, Rect)
{
+ rootPaintController().invalidateAll();
GraphicsContext context(rootPaintController());
LayoutRect bound = layoutView().viewRect();
drawRect(context, layoutView(), PaintPhaseForeground, bound);
@@ -64,6 +63,7 @@ TEST_F(LayoutObjectDrawingRecorderTest, Rect)
TEST_F(LayoutObjectDrawingRecorderTest, Cached)
{
+ rootPaintController().invalidateAll();
GraphicsContext context(rootPaintController());
LayoutRect bound = layoutView().viewRect();
drawNothing(context, layoutView(), PaintPhaseBlockBackground, bound);

Powered by Google App Engine
This is Rietveld 408576698