Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415133005: [Telemetry] Enable screenshot taking on Mac (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Enable screenshot taking on Mac BUG=369490 Committed: https://crrev.com/e887c296c741e723e6787ad4b684b65d3a59729d Cr-Commit-Position: refs/heads/master@{#356951}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use rgb(217, 115, 43) instead of green #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
A tools/telemetry/telemetry/core/platform_unittest.py View 1 1 chunk +37 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/mac_platform_backend.py View 2 chunks +7 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/internal/testing/screenshot_test.html View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nednguyen
5 years, 1 month ago (2015-10-29 19:18:25 UTC) #2
eakuefner
lgtm % question about test https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py File tools/telemetry/telemetry/core/platform_unittest.py (right): https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py#newcode33 tools/telemetry/telemetry/core/platform_unittest.py:33: green = bytearray([0, 255, ...
5 years, 1 month ago (2015-10-29 19:52:05 UTC) #3
eakuefner
https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py File tools/telemetry/telemetry/core/platform_unittest.py (right): https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py#newcode33 tools/telemetry/telemetry/core/platform_unittest.py:33: green = bytearray([0, 255, 0]) On 2015/10/29 at 19:52:05, ...
5 years, 1 month ago (2015-10-29 19:52:35 UTC) #4
nednguyen
On 2015/10/29 19:52:35, eakuefner wrote: > https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py > File tools/telemetry/telemetry/core/platform_unittest.py (right): > > https://codereview.chromium.org/1415133005/diff/1/tools/telemetry/telemetry/core/platform_unittest.py#newcode33 > ...
5 years, 1 month ago (2015-10-29 20:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415133005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415133005/20001
5 years, 1 month ago (2015-10-29 20:14:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 21:17:14 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e887c296c741e723e6787ad4b684b65d3a59729d Cr-Commit-Position: refs/heads/master@{#356951}
5 years, 1 month ago (2015-10-29 21:18:04 UTC) #10
dgozman
5 years, 1 month ago (2015-10-29 23:27:05 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1427033004/ by dgozman@chromium.org.

The reason for reverting is: Broke telemetry_unittests on Mac:
https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/8449.

Powered by Google App Engine
This is Rietveld 408576698