Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1415133003: Move SkChecksum::Murmur3 out of the header. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkChecksum::Murmur3 out of the header. As we use this more and more, we end up with more and more inline copies. On my desktop, this makes Skia ~16K smaller. Boy perf trybots would be neat. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e71000f0dfe05f99d33b1309325dba4e089519b3

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M gyp/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/private/SkChecksum.h View 1 chunk +1 line, -38 lines 0 comments Download
A src/core/SkChecksum.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mtklein_C
5 years, 2 months ago (2015-10-21 17:28:38 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415133003/20001
5 years, 2 months ago (2015-10-21 17:39:58 UTC) #9
reed1
Did you run nanobench locally?
5 years, 2 months ago (2015-10-21 17:45:24 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 17:49:39 UTC) #12
mtklein_C
Yep. Nothing obviously slowed down, not even compute_murmur3, the microbenchmark for this function.
5 years, 2 months ago (2015-10-21 18:04:13 UTC) #13
reed1
lgtm
5 years, 2 months ago (2015-10-21 18:27:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415133003/20001
5 years, 2 months ago (2015-10-21 18:52:50 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 18:53:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e71000f0dfe05f99d33b1309325dba4e089519b3

Powered by Google App Engine
This is Rietveld 408576698