Introduce a reference to the code object of inlined functions in CompilationInfo.

Introduce a reference to the code object of inlined functions in CompilationInfo.

The newly introduced root makes sure that we do not flush the
optimized code while the function is being compiled.

BUG=v8:4493
LOG=n

Committed: https://crrev.com/14ba9c3dea3ea6a597a63511fbed5190e74480bd
Cr-Commit-Position: refs/heads/master@{#31444}

[Jarin, 2015-10-21 13:17:10]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2015-10-21 13:17:10]

Could you take a look, please?

[Michael Starzinger, 2015-10-21 13:49:50]

LGTM. Scary stuff!

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:355: 
nit: Can we add a separator comment here, together with a comment that this is
the point where we decided that inlining is going to happen. It's the "point of
no return" for the inliner.

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:408: return NoChange();
nit: Can we add a TODO here that this bailout needs to be moved up to before the
line mentioned above?

[Jarin, 2015-10-21 14:31:46]

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:355: 
On 2015/10/21 13:49:50, Michael Starzinger wrote:
> nit: Can we add a separator comment here, together with a comment that this is
> the point where we decided that inlining is going to happen. It's the "point
of
> no return" for the inliner.

Done.

https://codereview.chromium.org/1415133002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:408: return NoChange();
On 2015/10/21 13:49:50, Michael Starzinger wrote:
> nit: Can we add a TODO here that this bailout needs to be moved up to before
the
> line mentioned above?

Done.

[Jarin, 2015-10-21 14:32:20]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2015-10-21 14:32:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1415133002/#ps40001
(title: "Tweak")

[commit-bot: I haz the power, 2015-10-21 14:32:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415133002/40001

[commit-bot: I haz the power, 2015-10-21 15:05:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-21 15:05:45]

Patchset 3 (id:??) landed as
https://crrev.com/14ba9c3dea3ea6a597a63511fbed5190e74480bd
Cr-Commit-Position: refs/heads/master@{#31444}