Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4716)

Unified Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 1415103006: Non-Local Join for Media Router and Presentation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Backwards Compatibility Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/router/media_router_android.cc
diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc
index 10e288989c5bb79977469146b195f6bb5ac00d54..c211c9ce44d50d503712a9ea014874b17ddb0617 100644
--- a/chrome/browser/media/android/router/media_router_android.cc
+++ b/chrome/browser/media/android/router/media_router_android.cc
@@ -105,6 +105,15 @@ void MediaRouterAndroid::CreateRoute(
route_request_id);
}
+void MediaRouterAndroid::ConnectRouteByRouteId(
+ const MediaSource::Id& source,
+ const MediaRoute::Id& route_id,
+ const GURL& origin,
+ content::WebContents* web_contents,
+ const std::vector<MediaRouteResponseCallback>& callbacks) {
+ NOTIMPLEMENTED();
+}
+
void MediaRouterAndroid::JoinRoute(
const MediaSource::Id& source_id,
const std::string& presentation_id,
@@ -260,6 +269,9 @@ void MediaRouterAndroid::UnregisterMediaSinksObserver(
void MediaRouterAndroid::RegisterMediaRoutesObserver(
MediaRoutesObserver* observer) {
DVLOG(2) << "Added MediaRoutesObserver: " << observer;
+ if (!observer->source_id().empty())
+ NOTIMPLEMENTED() << "Joinable routes query not implemented.";
+
routes_observers_.AddObserver(observer);
}
@@ -365,7 +377,7 @@ void MediaRouterAndroid::OnRouteCreated(
active_routes_.push_back(route);
FOR_EACH_OBSERVER(MediaRoutesObserver, routes_observers_,
- OnRoutesUpdated(active_routes_));
+ OnRoutesUpdated(active_routes_, std::vector<MediaRoute::Id>()));
}
void MediaRouterAndroid::OnRouteRequestError(
@@ -396,7 +408,7 @@ void MediaRouterAndroid::OnRouteClosed(JNIEnv* env,
}
FOR_EACH_OBSERVER(MediaRoutesObserver, routes_observers_,
- OnRoutesUpdated(active_routes_));
+ OnRoutesUpdated(active_routes_, std::vector<MediaRoute::Id>()));
}
void MediaRouterAndroid::OnMessageSentResult(

Powered by Google App Engine
This is Rietveld 408576698