Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: chrome/browser/resources/media_router/elements/route_details/route_details.js

Issue 1415103006: Non-Local Join for Media Router and Presentation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/route_details/route_details.js
diff --git a/chrome/browser/resources/media_router/elements/route_details/route_details.js b/chrome/browser/resources/media_router/elements/route_details/route_details.js
index 92ba82eccf98442b937c07126e479281c688eb5e..2b0f4ff99fdd210b0cbd1c09bf4ee5ebe90da012 100644
--- a/chrome/browser/resources/media_router/elements/route_details/route_details.js
+++ b/chrome/browser/resources/media_router/elements/route_details/route_details.js
@@ -47,6 +47,15 @@ Polymer({
},
/**
+ * The text for the join button.
+ * @private {string}
+ */
+ joinButtonText_: {
+ type: String,
imcheng 2015/12/01 23:45:06 readOnly: true
matt.boetger 2015/12/03 01:19:20 Done.
+ value: loadTimeData.getString('joinButton'),
+ },
+
+ /**
* The text for the stop casting button.
* @private {string}
*/
@@ -69,6 +78,16 @@ Polymer({
},
/**
+ * Fires a join-route-click event. This is called when the button to
imcheng 2015/12/01 23:45:06 to join
matt.boetger 2015/12/03 01:19:21 Done.
+ * the current route is clicked.
+ *
+ * @private
+ */
+ joinRoute_: function() {
imcheng 2015/12/01 23:45:06 I wonder if this should somehow go through media-r
matt.boetger 2015/12/03 01:19:20 Since all the route information is known at the ti
+ this.fire('join-route-click', {route: this.route});
+ },
+
+ /**
* Fires a close-route-click event. This is called when the button to close
* the current route is clicked.
*

Powered by Google App Engine
This is Rietveld 408576698