Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: chrome/browser/media/router/media_router.mojom

Issue 1415103006: Non-Local Join for Media Router and Presentation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready for Review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router.mojom
diff --git a/chrome/browser/media/router/media_router.mojom b/chrome/browser/media/router/media_router.mojom
index 2330a1e94c804abb5c5d7bfaee1502032ed59a4a..e3ec021d99b110e1cf67ca040d4d29a6d5e4990c 100644
--- a/chrome/browser/media/router/media_router.mojom
+++ b/chrome/browser/media/router/media_router.mojom
@@ -160,12 +160,16 @@ interface MediaRouteProvider {
StopObservingMediaSinks(string media_source);
// Starts reporting the state of active media routes via
- // OnRoutesUpdated(). Querying will continue until
+ // OnRoutesUpdated() in the context of the |media_source|.
+ // The |media_source| should be considered when returning joinable
+ // routes in the OnRoutesUpdated() call.
+ // Querying will continue until
// StopObservingMediaRoutes() is called.
imcheng 2015/11/26 00:49:45 nit: some of this can go in previous line?
matt.boetger 2015/12/01 01:26:56 Done.
- StartObservingMediaRoutes();
+ StartObservingMediaRoutes(string media_source);
- // Stops querying the state of all media routes.
- StopObservingMediaRoutes();
+ // Stops querying the state of all media routes in the context of
+ // the |media_source|.
+ StopObservingMediaRoutes(string media_source);
// Called when the MediaRouter is ready to get the next batch of messages
// associated with |route_id|.
@@ -214,7 +218,8 @@ interface MediaRouter {
OnIssue(Issue issue);
// Called when list of routes has been updated.
imcheng 2015/11/26 00:49:45 Could you pleae update documentation?
matt.boetger 2015/12/01 01:26:55 Done.
- OnRoutesUpdated(array<MediaRoute> routes);
+ OnRoutesUpdated(string media_source, array<MediaRoute> routes,
+ array<string> joinableRouteIds);
// Called when the overall availability of media sinks has been updated.
OnSinkAvailabilityUpdated(SinkAvailability availability);

Powered by Google App Engine
This is Rietveld 408576698