Non-Local Join for Media Router and Presentation API

chrome/browser/resources/media_router/media_router_ui_interface.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // API invoked by the browser MediaRouterWebUIMessageHandler to communicate
 // with this UI.
 cr.define('media_router.ui', function() {
   'use strict';
 
   // The media-router-container element.
@@ skipping 49 matching lines @@
    *   sinks - list of sinks to be displayed.
    *   routes - list of routes that are associated with the sinks.
    *   castModes - list of available cast modes.
    *   initialCastModeType - cast mode to show initially. Expected to be
    *       included in |castModes|.
    */
   function setInitialData(data) {
     container.deviceMissingUrl = data['deviceMissingUrl'];
     container.allSinks = data['sinks'];
     container.routeList = data['routes'];
+    container.joinableRouteList = data['joinableRoutes'];
     container.initializeCastModes(data['castModes'],
         data['initialCastModeType']);
   }
 
   /**
    * Sets current issue to |issue|, or clears the current issue if |issue| is
    * null.
    *
    * @param {?media_router.Issue} issue
    */
   function setIssue(issue) {
     container.issue = issue;
   }
 
   /**
    * Sets the list of currently active routes.
    *
    * @param {!Array<!media_router.Route>} routeList
+   * @param {!Array<!media_router.Route>} joinableRouteList
    */
-  function setRouteList(routeList) {
+  function setRouteList(routeList, joinableRouteList) {
     container.routeList = routeList;

[imcheng, 2015/11/19 18:55:08]

I would prefer an updateRouteList method in |container| that takes routeList and
a list of joinable route ids. Then inside that method it will set the canJoin
bits on a subset of routes accordingly.

[matt.boetger, 2015/11/24 19:45:24]

Done.

+    container.joinableRouteList = joinableRouteList;
   }
 
   /**
    * Sets the list of discovered sinks.
    *
    * @param {!Array<!media_router.Sink>} sinkList
    */
   function setSinkList(sinkList) {
     container.allSinks = sinkList;
   }
@@ skipping 36 matching lines @@
   /**
    * Closes the given route.
    *
    * @param {!media_router.Route} route
    */
   function closeRoute(route) {
     chrome.send('closeRoute', [{routeId: route.id}]);
   }
 
   /**
+   * Joins the given route.
+   *
+   * @param {!media_router.Route} route
+   */
+  function joinRoute(route) {
+    chrome.send('joinRoute', [{sinkId: route.sinkId, routeId: route.id}]);
+  }
+
+  /**
    * Reports the current number of sinks.
    *
    * @param {number} sinkCount
    */
   function reportSinkCount(sinkCount) {
     chrome.send('reportSinkCount', [sinkCount]);
   }
 
   /**
    * Requests data to initialize the WebUI with.
@@ skipping 12 matching lines @@
    */
   function requestRoute(sinkId, selectedCastMode) {
     chrome.send('requestRoute',
                 [{sinkId: sinkId, selectedCastMode: selectedCastMode}]);
   }
 
   return {
     actOnIssue: actOnIssue,
     closeDialog: closeDialog,
     closeRoute: closeRoute,
+    joinRoute: joinRoute,
     reportSinkCount: reportSinkCount,
     requestInitialData: requestInitialData,
     requestRoute: requestRoute,
   };
 });