Non-Local Join for Media Router and Presentation API

chrome/browser/resources/media_router/elements/route_details/route_details.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This Polymer element shows information from media that is currently cast
 // to a device. It is assumed that |route| and |sink| correspond to each other.
 Polymer({
   is: 'route-details',
 
   properties: {
@@ skipping 29 matching lines @@
     /**
      * The sink to show.
      * @type {?media_router.Sink}
      */
     sink: {
       type: Object,
       value: null,
     },
 
     /**
+     * The text for the join casting button.
+     * @private {string}
+     */
+    joinCastingButtonText_: {
+      type: String,
+      value: loadTimeData.getString('joinCastingButton'),

[imcheng, 2015/11/19 18:55:08]

joinButton ?

[matt.boetger, 2015/11/24 19:45:24]

Same could be said for the stop button - but I wanted to be consistent.

[imcheng, 2015/11/26 00:49:45]

For stop button, it is named so because the button says "Stop casting". Since
the join button will say "Join", joinButton is the right name for the resource.

[matt.boetger, 2015/12/01 01:26:55]

Done.

+    },
+
+    /**
      * The text for the stop casting button.
      * @private {string}
      */
     stopCastingButtonText_: {
       type: String,
       readOnly: true,
       value: loadTimeData.getString('stopCastingButton'),
     },
 
     /**
      * Whether the custom controller should be hidden.
      * A custom controller is shown iff |route| specifies customControllerPath
      * and the view can be loaded.
      * @private {boolean}
      */
     isCustomControllerHidden_: {
       type: Boolean,
       value: true,
     },
   },
 
   /**
+   * Fires a join-route-click event. This is called when the button to
+   * the current route is clicked.
+   *
+   * @private
+   */
+  joinRoute_: function() {
+    this.fire('join-route-click', {route: this.route});
+  },
+
+  /**
    * Fires a close-route-click event. This is called when the button to close
    * the current route is clicked.
    *
    * @private
    */
   closeRoute_: function() {
     this.fire('close-route-click', {route: this.route});
   },
 
   /**
@@ skipping 26 matching lines @@
     extensionview.load(this.route.customControllerPath)
     .then(function() {
       // Load was successful; show the custom controller.
       that.isCustomControllerHidden_ = false;
     }, function() {
       // Load was unsuccessful; fall back to default view.
       that.isCustomControllerHidden_ = true;
     });
   },
 });