Non-Local Join for Media Router and Presentation API

chrome/browser/media/router/media_routes_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTES_OBSERVER_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTES_OBSERVER_H_
 
 #include <vector>
 
 #include "base/macros.h"
 #include "chrome/browser/media/router/media_route.h"
 
 namespace media_router {
 
 class MediaRouter;
 
 // Base class for observing when the set of MediaRoutes and their associated
 // MediaSinks have been updated.
 class MediaRoutesObserver {
  public:
-  explicit MediaRoutesObserver(MediaRouter* router);
+  explicit MediaRoutesObserver(MediaRouter* router,
+      const MediaSource::Id source_id = std::string(""));

[imcheng, 2015/11/19 18:55:08]

const MediaSource::Id& source_id = MediaSource::Id()

[matt.boetger, 2015/11/24 19:45:23]

Done.

   virtual ~MediaRoutesObserver();
 
   // Invoked when the list of routes and their associated sinks have been

[imcheng, 2015/11/19 18:55:08]

Could you update comments?

[matt.boetger, 2015/11/24 19:45:23]

Done.

   // updated.
   // Implementations may not perform operations that modify the Media Router's
   // observer list. In particular, invoking this observer's destructor within
   // OnRoutesUpdated will result in undefined behavior.
-  virtual void OnRoutesUpdated(const std::vector<MediaRoute>& routes) {}
+  virtual void OnRoutesUpdated(
+      const MediaSource::Id source_id,

[imcheng, 2015/11/19 18:55:08]

Is |source_id| needed? MR should ensure that |source_id| == |source_id_|.

[matt.boetger, 2015/11/24 19:45:23]

Done.

+      const std::vector<MediaRoute>& routes,
+      const std::vector<MediaRoute>& joinable_routes) {}
+
+  const MediaSource::Id source_id() const { return source_id_; }
 
  private:
   MediaRouter* router_;
+  const MediaSource::Id source_id_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRoutesObserver);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTES_OBSERVER_H_