Non-Local Join for Media Router and Presentation API

chrome/browser/media/router/media_router.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module media_router.interfaces;
 
 // Represents an output sink to which media can be routed.
 struct MediaSink {
   enum IconType {
     CAST,
@@ skipping 143 matching lines @@
       => (bool sent);
 
   // Starts querying for sinks capable of displaying |media_source|.
   StartObservingMediaSinks(string media_source);
 
   // Stops querying sinks for |media_source|.
   StopObservingMediaSinks(string media_source);
 
   // Starts reporting the state of active media routes via
   // OnRoutesUpdated(). Querying will continue until
   // StopObservingMediaRoutes() is called.

[imcheng, 2015/11/19 18:55:08]

Please update comments.

[matt.boetger, 2015/11/24 19:45:23]

Done.

-  StartObservingMediaRoutes();
+  StartObservingMediaRoutes(string media_source);
 
   // Stops querying the state of all media routes.

[imcheng, 2015/11/19 18:55:08]

ditto

[matt.boetger, 2015/11/24 19:45:23]

Done.

-  StopObservingMediaRoutes();
+  StopObservingMediaRoutes(string media_source);
 
   // Called when the MediaRouter is ready to get the next batch of messages
   // associated with |route_id|.
   // |messages| returned will contain the batch of messages.
   // |messages| will be empty if |StopListeningForRouteMessages| was invoked.
   // |error| indicates if a permanent error occurred. If true, then subsequent
   // calls will also return with |error| being true.
   ListenForRouteMessages(string route_id) =>
       (array<RouteMessage> messages, bool error);
 
@@ skipping 28 matching lines @@
   RegisterMediaRouteProvider(MediaRouteProvider media_router_provider) =>
       (string instance_id);
 
   // Called when the Media Route Manager receives a new list of sinks.
   OnSinksReceived(string media_source, array<MediaSink> sinks);
 
   // Called when issues are reported for media routes.
   OnIssue(Issue issue);
 
   // Called when list of routes has been updated.
-  OnRoutesUpdated(array<MediaRoute> routes);
+  OnRoutesUpdated(string media_source, array<MediaRoute> routes,
+    array<MediaRoute> joinableRoutes);

[imcheng, 2015/11/19 18:55:08]

+2 indent

[imcheng, 2015/11/19 18:55:08]

Since joinableRoutes is a subset of routes, would it be possible for it to be
just route ids?

[matt.boetger, 2015/11/24 19:45:23]

Done.

[matt.boetger, 2015/11/24 19:45:23]

Done.

 
   // Called when the overall availability of media sinks has been updated.
   OnSinkAvailabilityUpdated(SinkAvailability availability);
 };