Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1415103005: Remove NOTIMPLEMENTED for SurfaceFactoryClient::SetBeginFrameSource's (Closed)

Created:
5 years, 1 month ago by brianderson
Modified:
5 years, 1 month ago
Reviewers:
no sievers, boliu, sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, android-webview-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, cc-bugs_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NOTIMPLEMENTED for SurfaceFactoryClient::SetBeginFrameSource's It's too noisy. Kept the TODOs though. BUG=547843 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ea1e159e5ab8b5221b1f43e4cff8a1f92fdf5f17 Cr-Commit-Position: refs/heads/master@{#356615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M android_webview/browser/hardware_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/surfaces/top_level_display_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
brianderson
Ptal. Should be a quick review. People have been complaining about the noisiness of this ...
5 years, 1 month ago (2015-10-28 00:16:24 UTC) #2
boliu
On 2015/10/28 00:16:24, brianderson wrote: > Ptal. Should be a quick review. People have been ...
5 years, 1 month ago (2015-10-28 00:19:30 UTC) #3
sky
LGTM
5 years, 1 month ago (2015-10-28 15:43:36 UTC) #4
no sievers
lgtm
5 years, 1 month ago (2015-10-28 19:02:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415103005/1
5 years, 1 month ago (2015-10-28 19:04:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 19:38:39 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 19:40:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea1e159e5ab8b5221b1f43e4cff8a1f92fdf5f17
Cr-Commit-Position: refs/heads/master@{#356615}

Powered by Google App Engine
This is Rietveld 408576698