Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1415093006: [Interpreter] Add switch support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_wideidx
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/control-flow-builders.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index 2f547721abd82aa375d34d877eaa9655d642a8da..0feec99709c616ed14a2a44a22c91732ca23bede 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -4341,6 +4341,228 @@ TEST(Conditional) {
}
}
+
+TEST(Switch) {
+ InitializedHandleScope handle_scope;
+ BytecodeGeneratorHelper helper;
+
+ ExpectedSnippet<int> snippets[] = {
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: return 2;\n"
+ " case 2: return 3;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 30,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), // The tag variable is allocated as a
+ B(Ldar), R(1), // local by the parser, hence this
+ B(Star), R(0), // strange shuffling.
+ B(LdaSmi8), U8(1), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(7), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(2), //
+ B(Return), //
+ B(LdaSmi8), U8(3), //
+ B(Return), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: a = 2; break;\n"
+ " case 2: a = 3; break;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 36,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(1), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(Jump), U8(14), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(1), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case 1: a = 2; // fall-through\n"
+ " case 2: a = 3; break;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 34,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(1), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(8), //
+ B(Jump), U8(12), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(1), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case 2: break;\n"
+ " case 3: break;\n"
+ " default: a = 1; break;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 34,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(3), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(6), //
+ B(Jump), U8(6), //
+ B(Jump), U8(10), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(typeof(a)) {\n"
+ " case 2: a = 1; break;\n"
+ " case 3: a = 2; break;\n"
+ " default: a = 3; break;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 43,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(TypeOf), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(3), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(Jump), U8(14), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Jump), U8(14), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(1), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case typeof(a): a = 1; break;\n"
+ " default: a = 2; break;\n"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 31,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(0), //
+ B(Ldar), R(1), //
+ B(TypeOf), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(4), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ }},
+ {"var a = 1;\n"
+ "switch(a) {\n"
+ " case 1:\n" REPEAT_64(SPACE, " a = 2;")
+ "break;\n"
+ " case 2: a = 3; break;"
+ "}\n",
+ 2 * kPointerSize,
+ 1,
+ 288,
+ {
+ B(LdaSmi8), U8(1), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(1), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrue), U8(10), //
+ B(LdaSmi8), U8(2), //
+ B(TestEqualStrict), R(0), //
+ B(JumpIfTrueConstant), U8(0), //
+ B(JumpConstant), U8(1), //
+ REPEAT_64(COMMA, //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(1)), //
+ B(Jump), U8(8), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(1), //
+ B(Jump), U8(2), //
+ B(LdaUndefined), //
+ B(Return), //
+ },
+ 2,
+ {262, 266}},
+ };
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ Handle<BytecodeArray> bytecode_array =
+ helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
+ CheckBytecodeArrayEqual(snippets[i], bytecode_array);
+ }
+}
+
} // namespace interpreter
} // namespace internal
} // namespace v8
« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/control-flow-builders.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698