Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415063002: Add /bug redirects to the home page AppEngine app (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
crashpad-dev_chromium.org, Robert Sesek
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add /bug redirects to the home page AppEngine app /bug/ redirects to the Crashpad project on Monorail. /bug/new redirects to the “new issue” screen, and /bug/123 redirects to the named bug. R=andybons@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0ed0106aa4f2b146353275e24de75cdef4fb9f6c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M doc/appengine/main.go View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-21 01:08:29 UTC) #2
Bons
On 2015/10/21 at 01:08:29, mark wrote: > lgtm
5 years, 2 months ago (2015-10-21 01:49:46 UTC) #3
Bons
https://codereview.chromium.org/1415063002/diff/1/doc/appengine/main.go File doc/appengine/main.go (right): https://codereview.chromium.org/1415063002/diff/1/doc/appengine/main.go#newcode39 doc/appengine/main.go:39: const baseURL = "https://chromium.googlesource.com/crashpad/crashpad/+/doc/doc/generated/?format=TEXT" this can be const ( ...
5 years, 2 months ago (2015-10-21 01:50:04 UTC) #4
Mark Mentovai
https://codereview.chromium.org/1415063002/diff/1/doc/appengine/main.go File doc/appengine/main.go (right): https://codereview.chromium.org/1415063002/diff/1/doc/appengine/main.go#newcode39 doc/appengine/main.go:39: const baseURL = "https://chromium.googlesource.com/crashpad/crashpad/+/doc/doc/generated/?format=TEXT" Bons wrote: > this can ...
5 years, 2 months ago (2015-10-21 01:53:41 UTC) #5
Mark Mentovai
5 years, 2 months ago (2015-10-21 13:42:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0ed0106aa4f2b146353275e24de75cdef4fb9f6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698