Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1415023007: X87: fix a check error for deoptimization. (Closed)

Created:
5 years, 1 month ago by chunyang.dai
Modified:
5 years, 1 month ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: fix a check error for deoptimization. This CL is a fix for https://codereview.chromium.org/1411223010. (X87: fix the deoptimization issue.). ArchDeoptimize instruction may contains duplicated x87 double register as input parameters. So the scope check is not correct. BUG= Committed: https://crrev.com/fd0d9cf2c53b2963c456e5c5c697e824f7dce305 Cr-Commit-Position: refs/heads/master@{#31812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 1 month ago (2015-11-05 02:28:13 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-05 02:31:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415023007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415023007/1
5 years, 1 month ago (2015-11-05 02:31:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 02:51:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 02:52:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd0d9cf2c53b2963c456e5c5c697e824f7dce305
Cr-Commit-Position: refs/heads/master@{#31812}

Powered by Google App Engine
This is Rietveld 408576698