Change cctest/test-lockers to not copy persistent handles around.

Change cctest/test-lockers to not copy persistent handles around.

Instead, create Local handles to pass them around. This also means that the
code needs to be shifted around a bit such that a handle scope exists when
creating threads.

Committed: https://code.google.com/p/v8/source/detail?r=14420

[jochen (gone - plz use gerrit), 2013-04-24 12:55:02]

plz review :)

the tests pass locally in ia32.debug

[dcarney, 2013-04-24 13:13:30]

lgtm

[dcarney, 2013-04-24 13:13:38]

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.cc
File test/cctest/test-lockers.cc (right):

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.c...
test/cctest/test-lockers.cc:501: thread;
spacing

[jochen (gone - plz use gerrit), 2013-04-24 13:15:16]

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.cc
File test/cctest/test-lockers.cc (right):

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.c...
test/cctest/test-lockers.cc:501: thread;
On 2013/04/24 13:13:38, dcarney wrote:
> spacing

that's the way the google c++ style wants it (since it's the type not fitting on
the one line)

[Sven Panne, 2013-04-24 13:40:39]

LGTM with a nit, too.

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.cc
File test/cctest/test-lockers.cc (right):

https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.c...
test/cctest/test-lockers.cc:501: thread;
On 2013/04/24 13:15:16, jochen wrote:
> On 2013/04/24 13:13:38, dcarney wrote:
> > spacing
> 
> that's the way the google c++ style wants it (since it's the type not fitting
on
> the one line)

Perhaps we can resolve this dispute by using i::SmartPointer? :-)

[dcarney, 2013-04-24 13:46:02]

https://codereview.chromium.org/14150017/diff/3001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/14150017/diff/3001/include/v8.h#newcode380
include/v8.h:380: : Handle<T>(New(isolate, that)) { }
Should be a comment here.  This is required for handlocalypse, but is a HUGE
departure from the V8 api, since it's a call to New without being explicit.

[jochen (gone - plz use gerrit), 2013-04-24 14:20:02]

addressed both comments

[dcarney, 2013-04-24 14:24:19]

Committed patchset #3 manually as r14420 (presubmit successful).