Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: tools/dom/scripts/dartgenerator.py

Issue 14150007: Drop raises annotations support. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/idl/dart/dart.idl ('k') | tools/dom/scripts/generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/dartgenerator.py
diff --git a/tools/dom/scripts/dartgenerator.py b/tools/dom/scripts/dartgenerator.py
index fdac363518c8b48a7f918e11d908944335e11d5c..4fd476cba9b364feb0b5fe33b20c2209a3e2b926 100755
--- a/tools/dom/scripts/dartgenerator.py
+++ b/tools/dom/scripts/dartgenerator.py
@@ -165,10 +165,6 @@ class DartGenerator(object):
continue
interfaces.append(interface)
- # TODO(sra): Use this list of exception names to generate information to
- # tell dart2js which exceptions can be passed from JS to Dart code.
- exceptions = self._CollectExceptions(interfaces)
-
# Render all interfaces into Dart and save them in files.
for interface in self._PreOrderInterfaces(interfaces):
interface_name = interface.id
@@ -201,21 +197,6 @@ class DartGenerator(object):
visit(interface)
return ordered
- def _CollectExceptions(self, interfaces):
- """Returns the names of all exception classes raised."""
- exceptions = set()
- for interface in interfaces:
- for attribute in interface.attributes:
- if attribute.get_raises:
- exceptions.add(attribute.get_raises.id)
- if attribute.set_raises:
- exceptions.add(attribute.set_raises.id)
- for operation in interface.operations:
- if operation.raises:
- exceptions.add(operation.raises.id)
- return exceptions
-
-
def FixEventTargets(self, database):
for interface in database.GetInterfaces():
# Create fake EventTarget parent interface for interfaces that have
« no previous file with comments | « tools/dom/idl/dart/dart.idl ('k') | tools/dom/scripts/generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698