content/renderer/media/video_capture_impl.cc - Issue 14150004: Fix problem where a video frame buffer is freed while it is still in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_capture_impl.cc

Issue 14150004: Fix problem where a video frame buffer is freed while it is still in use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/video_capture_impl.cc

diff --git a/content/renderer/media/video_capture_impl.cc b/content/renderer/media/video_capture_impl.cc

index ebc7a6bfecfe2702a4365e07e2e0e030e5b8f837..524b639409268a00b37091630fe6dc4ef499294a 100644

--- a/content/renderer/media/video_capture_impl.cc

+++ b/content/renderer/media/video_capture_impl.cc

@@ -323,7 +323,6 @@ void VideoCaptureImpl::DoStateChangedOnCaptureThread(VideoCaptureState state) {

break;

case VIDEO_CAPTURE_STATE_ENDED:

DVLOG(1) << "OnStateChanged: ended!, device_id = " << device_id_;

- STLDeleteValues(&cached_dibs_);

for (ClientInfo::iterator it = clients_.begin();

it != clients_.end(); ++it) {

it->first->OnRemoved(this);

« no previous file with comments | « no previous file | no next file » | no next file with comments »