Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: sdk/lib/async/stream.dart

Issue 14150002: Remove StreamSink(replaced by EventSink) and make IOSink extend EventSink. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/collection_sink.dart ('k') | sdk/lib/async/stream_controller.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream.dart
diff --git a/sdk/lib/async/stream.dart b/sdk/lib/async/stream.dart
index c1699f0d636b1a22025551fcd36f9d5ccc4f3674..7f0cfa46727da8431fae3fb585fc67484b00fce7 100644
--- a/sdk/lib/async/stream.dart
+++ b/sdk/lib/async/stream.dart
@@ -921,16 +921,6 @@ abstract class StreamSubscription<T> {
/**
- * *Deprecated*. Use [EventSink] instead.
- */
-abstract class StreamSink<T> extends EventSink<T>{
- /* TODO(8997): Remove class.*/
- /** *Deprecated*. Use [EventSink.addError] instead.*/
- void signalError(AsyncError errorEvent) { addError(errorEvent); }
-}
-
-
-/**
* An interface that abstracts creation or handling of [Stream] events.
*/
abstract class EventSink<T> {
@@ -939,7 +929,7 @@ abstract class EventSink<T> {
/** Create an async error. */
void addError(AsyncError errorEvent);
/** Request a stream to close. */
- void close();
+ close();
floitsch 2013/04/11 12:45:01 keep. The EventSink.close should be assumed not to
Anders Johnsen 2013/04/11 12:53:05 Done.
}
@@ -965,7 +955,7 @@ class StreamView<T> extends Stream<T> {
/**
* [EventSink] wrapper that only exposes the [EventSink] interface.
*/
-class EventSinkView<T> extends StreamSink<T> {
+class EventSinkView<T> extends EventSink<T> {
// TODO(8997): Implment EventSink instead.
final EventSink<T> _sink;
@@ -1226,7 +1216,7 @@ class _EventTransformStreamSubscription<S, T>
}
/* TODO(8997): Implement EventSink instead, */
floitsch 2013/04/11 12:45:01 Remove TODO.
Anders Johnsen 2013/04/11 12:53:05 Done.
-class _EventOutputSinkWrapper<T> extends StreamSink<T> {
+class _EventOutputSinkWrapper<T> extends EventSink<T> {
_EventOutputSink _sink;
_EventOutputSinkWrapper(this._sink);
« no previous file with comments | « sdk/lib/async/collection_sink.dart ('k') | sdk/lib/async/stream_controller.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698