Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1414983004: CMake: exclude SkOSLibrary_posix.cpp on Windows too. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
Marco A., mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake: exclude SkOSLibrary_posix.cpp on Windows too. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/e092cee9ad96c8df1af05dcb0c078874b67c1a8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cmake/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 1 month ago (2015-10-26 14:59:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414983004/1
5 years, 1 month ago (2015-10-26 14:59:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 15:16:53 UTC) #6
Marco A.
lgtm Works for me. Lgtm!
5 years, 1 month ago (2015-10-26 15:38:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414983004/1
5 years, 1 month ago (2015-10-26 15:40:22 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:41:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e092cee9ad96c8df1af05dcb0c078874b67c1a8e

Powered by Google App Engine
This is Rietveld 408576698