net/url_request/url_request_test_job.h - Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_test_job.h

Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments mmenke Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc ('k') | net/url_request/url_request_test_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_test_job.h

diff --git a/net/url_request/url_request_test_job.h b/net/url_request/url_request_test_job.h

index db88fb819d00f3fcfa730d198a800cfc844f1ff0..09b31a41e2cf787f718f071c1d68c8e31dfa2d94 100644

--- a/net/url_request/url_request_test_job.h

+++ b/net/url_request/url_request_test_job.h

@@ -50,8 +50,8 @@ class NET_EXPORT_PRIVATE URLRequestTestJob : public URLRequestJob {

bool auto_advance);

// Constructs a job to return the given response regardless of the request

- // url. The headers should include the HTTP status line and be formatted as

- // expected by HttpResponseHeaders.

+ // url. The headers should include the HTTP status line and use CRLF/LF as the

+ // line separator.

URLRequestTestJob(URLRequest* request,

NetworkDelegate* network_delegate,

const std::string& response_headers,