content/browser/service_worker/service_worker_browsertest.cc - Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments mmenke Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index b841b1862894514f24527879abbcf2164e7fba98..1619dd27c8cd09e6f43761545c8111c9940aade3 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -235,10 +235,10 @@ class LongLivedResourceInterceptor : public net::URLRequestInterceptor {

net::URLRequest* request,

net::NetworkDelegate* network_delegate) const override {

const char kHeaders[] =

- "HTTP/1.1 200 OK\0"

- "Content-Type: text/javascript\0"

- "Expires: Thu, 1 Jan 2100 20:00:00 GMT\0"

- "\0";

+ "HTTP/1.1 200 OK\n"

+ "Content-Type: text/javascript\n"

+ "Expires: Thu, 1 Jan 2100 20:00:00 GMT\n"

+ "\n";

std::string headers(kHeaders, arraysize(kHeaders));

return new net::URLRequestTestJob(

request, network_delegate, headers, body_, true);