Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5183)

Unified Diff: core/include/fpdfapi/fpdf_objects.h

Issue 1414963005: Remove default argument from CPDF_Dictionary::SetAt(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/include/fpdfapi/fpdf_objects.h
diff --git a/core/include/fpdfapi/fpdf_objects.h b/core/include/fpdfapi/fpdf_objects.h
index 419d5fc23e69b12ad7a46a33ba90f57acf2f8dcc..d6050aec0b5485caf78d72ce8a5fc60c395e66d4 100644
--- a/core/include/fpdfapi/fpdf_objects.h
+++ b/core/include/fpdfapi/fpdf_objects.h
@@ -410,9 +410,7 @@ class CPDF_Dictionary : public CPDF_Object {
CPDF_Object* GetNextElement(FX_POSITION& pos, CFX_ByteString& key) const;
- void SetAt(const CFX_ByteStringC& key,
- CPDF_Object* pObj,
- CPDF_IndirectObjects* pObjs = NULL);
+ void SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj);
void SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);
@@ -436,12 +434,6 @@ class CPDF_Dictionary : public CPDF_Object {
CPDF_IndirectObjects* pDoc,
FX_DWORD objnum);
- void AddReference(const CFX_ByteStringC& key,
- CPDF_IndirectObjects* pDoc,
- CPDF_Object* obj) {
- AddReference(key, pDoc, obj->GetObjNum());
- }
-
void SetAtRect(const CFX_ByteStringC& key, const CFX_FloatRect& rect);
void SetAtMatrix(const CFX_ByteStringC& key, const CFX_AffineMatrix& matrix);

Powered by Google App Engine
This is Rietveld 408576698