core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp - Issue 1414963005: Remove default argument from CPDF_Dictionary::SetAt().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

Issue 1414963005: Remove default argument from CPDF_Dictionary::SetAt(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

index dd416fbd57a256f5441153b46ea6c52efc9c4c52..591bfcaa8c63ee7015c923de73af2e6fe2b33b91 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

@@ -866,7 +866,8 @@ FX_BOOL CPDF_Parser::RebuildCrossRef() {

CFX_ByteString key;

CPDF_Object* pObj =

pTrailer->GetNextElement(pos, key);

- m_pTrailer->SetAt(key, pObj->Clone(), m_pDocument);

+ m_pTrailer->SetAtWithIndirect(key, pObj->Clone(),

+ m_pDocument);

}

pObj->Release();

} else {