runtime/vm/flow_graph_inliner.cc - Issue 1414933006: Copy ICData descriptors when starting background compilation, so that they do not change while comp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1414933006: Copy ICData descriptors when starting background compilation, so that they do not change while comp… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_inliner.cc

diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc

index cfffa8f6ad25f660d83c008e8ab1baa6fe2f5c80..930da8dd41c235c664bacb15c141b9c091d91138 100644

--- a/runtime/vm/flow_graph_inliner.cc

+++ b/runtime/vm/flow_graph_inliner.cc

@@ -700,7 +700,8 @@ class CallSiteInliner : public ValueObject {

// Load IC data for the callee.

ZoneGrowableArray<const ICData*>* ic_data_array =

new(Z) ZoneGrowableArray<const ICData*>();

- function.RestoreICDataMap(ic_data_array);

+ const bool clone_descriptors = Compiler::IsBackgroundCompilation();

+ function.RestoreICDataMap(ic_data_array, clone_descriptors);

// Build the callee graph.

InlineExitCollector* exit_collector =

« no previous file with comments | « runtime/vm/coverage.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »