Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: presubmit_canned_checks.py

Issue 141493002: Add a canned clang-format presubmit check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Rebased Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index b11102a94332c8e727dbeccb8b5b44c69563d723..d52ad9582df3a2c2e81809054a903f0754694ca6 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -1041,3 +1041,15 @@ def PanProjectChecks(input_api, output_api,
input_api, output_api))
snapshot("done")
return results
+
+
+def CheckPatchFormatted(input_api, output_api):
+ import git_cl
+ code, _ = git_cl.RunGitWithCode(['cl', 'format', '--dry-run'],
+ suppress_stderr=True)
+ if code == 2:
+ return [output_api.PresubmitPromptWarning(
+ 'Your patch is not formatted, please run git cl format.')]
+ # As this is just a warning, ignore all other errors if the user
+ # happens to have a broken clang-format, doesn't use git, etc etc.
+ return []
« no previous file with comments | « git_cl.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698