Chromium Code Reviews

Issue 1414923008: Revert of Generalize python_git_runner for use in non-git scripts. (Closed)

Created:
5 years, 1 month ago by Adrian Kuegel
Modified:
5 years, 1 month ago
Reviewers:
iannucci1, iannucci, Michael Moss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
depot_tools
Visibility:
Public.

Description

Revert of Generalize python_git_runner for use in non-git scripts. (patchset #1 id:1 of https://codereview.chromium.org/1415993003/ ) Reason for revert: Speculative revert in case this caused the bots to fail bot_update. Original issue's description: > Generalize python_git_runner for use in non-git scripts. > > Also fixes an msys (git-bash) incompatibility, similar to the one > fixed in crrev.com/4845f0ed694ff071da5f6ee937a0bce2ea4e6fd2. > > This change doesn't actually use the wrapper in any new places, but > subsequent changes will be made to use it in places where > 'exec python' is called directly, like gclient and fetch. > > BUG=411518 > R=iannucci@google.com > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297357 TBR=iannucci@google.com,iannucci@chromium.org,mmoss@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=411518 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297358

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+58 lines, -58 lines)
M git-auto-svn View 1 chunk +1 line, -1 line 0 comments
M git-cache View 1 chunk +1 line, -1 line 0 comments
M git-cherry-pick-upload View 1 chunk +1 line, -1 line 0 comments
M git-cl View 1 chunk +1 line, -1 line 0 comments
M git-drover View 1 chunk +1 line, -1 line 0 comments
M git-find-releases View 1 chunk +1 line, -1 line 0 comments
M git-footers View 1 chunk +1 line, -1 line 0 comments
M git-freeze View 1 chunk +1 line, -1 line 0 comments
M git-map View 1 chunk +1 line, -1 line 0 comments
M git-map-branches View 1 chunk +1 line, -1 line 0 comments
M git-mark-merge-base View 1 chunk +1 line, -1 line 0 comments
M git-nav-downstream View 1 chunk +1 line, -1 line 0 comments
M git-new-branch View 1 chunk +1 line, -1 line 0 comments
M git-number View 1 chunk +1 line, -1 line 0 comments
M git-rebase-update View 1 chunk +1 line, -1 line 0 comments
M git-rename-branch View 1 chunk +1 line, -1 line 0 comments
M git-reparent-branch View 1 chunk +1 line, -1 line 0 comments
M git-retry View 1 chunk +1 line, -1 line 0 comments
M git-squash-branch View 1 chunk +1 line, -1 line 0 comments
M git-thaw View 1 chunk +1 line, -1 line 0 comments
M git-try View 1 chunk +1 line, -1 line 0 comments
M git-upstream-diff View 1 chunk +1 line, -1 line 0 comments
A python_git_runner.sh View 1 chunk +36 lines, -0 lines 0 comments
D python_runner.sh View 1 chunk +0 lines, -36 lines 0 comments

Messages

Total messages: 3 (0 generated)
Adrian Kuegel
Created Revert of Generalize python_git_runner for use in non-git scripts.
5 years, 1 month ago (2015-10-28 15:41:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414923008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414923008/1
5 years, 1 month ago (2015-10-28 15:41:10 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 15:41:26 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297358

Powered by Google App Engine