Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1414923006: Revert of Avoid Copying damage rect when using Overlays (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid Copying damage rect when using Overlays (patchset #12 id:220001 of https://codereview.chromium.org/1330563004/ ) Reason for revert: The reason for revert: use-of-uninitiailzed value is reported on msan bot. Filed crbug.com/548452 [ RUN ] SandwichTest.MultiQuadOverlay ==7008==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f1d2774a400 in cc::OverlayProcessor::ProcessForOverlays(cc::ResourceProvider*, cc::ScopedPtrVector\u003Ccc::RenderPass>*, std::__1::vector\u003Ccc::OverlayCandidate, std::__1::allocator\u003Ccc::OverlayCandidate> >*, gfx::Rect*) cc/output/overlay_processor.cc:45:13 #1 0x7f1d259f6e5e in cc::(anonymous namespace)::SandwichTest_MultiQuadOverlay_Test::TestBody() cc/output/overlay_unittest.cc:617:3 #2 0x7f1d274a3922 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2458:12 Original issue's description: > Avoid Copying damage rect when using Overlays > > When using Overlays, the damage rect can be completely covered by > the layer being composited by Overlay. We still copy damage rect > on to the current surface(Primary frame buffer) in BufferQueue. This > should be un-necessary. > > BUG=370522 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/2904998edff0cfcaab43eeb3b1db013d6169bd17 > Cr-Commit-Position: refs/heads/master@{#356352} TBR=alexst@chromium.org,achaulk@chromium.org,danakj@chromium.org,ccameron@chromium.org,piman@chromium.org,kalyan.kondapally@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=370522 Committed: https://crrev.com/6a01f994b36782395119772fc72cce1d74104db9 Cr-Commit-Position: refs/heads/master@{#356427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -134 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/overlay_candidate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/overlay_candidate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/overlay_processor.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/overlay_processor.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M cc/output/overlay_unittest.cc View 38 chunks +82 lines, -105 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
Created Revert of Avoid Copying damage rect when using Overlays
5 years, 1 month ago (2015-10-27 23:12:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414923006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414923006/1
5 years, 1 month ago (2015-10-27 23:15:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 23:18:34 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 23:19:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a01f994b36782395119772fc72cce1d74104db9
Cr-Commit-Position: refs/heads/master@{#356427}

Powered by Google App Engine
This is Rietveld 408576698